-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixing breaking changes in rekor v1.12.0 upgrade #2260
Conversation
Signed-off-by: Batuhan Apaydın <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minus that I think the test code also needed to be changed. Happy to push a fix for that.
return types.NewProposedEntry(ctx, intoto.KIND, intoto_v001.APIVERSION, types.ArtifactProperties{ | ||
ArtifactBytes: signature, | ||
PublicKeyBytes: pubKey, | ||
PublicKeyBytes: pubKeyBytes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had to check up on why the rekorEntry
function here that reconstructs hashedrekord types didn't need to be changed: that directly creates a v0.0.1 hashed rekord type, instead of relying on the general entry construction.
Just ran into a problem that we can't generate a rekor entry for testing for intoto v0.0.1 at 0.12.0 because v0.0.1 intoto was explicitly not supported. We need Priya's fix here: sigstore/rekor@a6d36b8 |
Signed-off-by: Asra Ali <[email protected]>
I think you may have branch protection on! (didn't expect anything less!) But this PR is updated with two commits in my fork: https://github.com/asraa/cosign/tree/fix-rekorv112 |
Codecov Report
@@ Coverage Diff @@
## main #2260 +/- ##
==========================================
- Coverage 28.56% 28.54% -0.03%
==========================================
Files 131 131
Lines 7855 7866 +11
==========================================
+ Hits 2244 2245 +1
- Misses 5305 5314 +9
- Partials 306 307 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Asra Ali <[email protected]> Signed-off-by: Batuhan Apaydın <[email protected]>
a74dd99
to
4621231
Compare
Is this one ready to go @asraa ? |
This is blocking 0.12 rolling out to prod, so this should be prioritized. |
what still needs to happen here? cc @asraa ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that! LGTM -- the tests have the change now
Signed-off-by: Batuhan Apaydın [email protected]
This PR aims to fix breaking changes in Rekor v1.12.0 pkg
Summary
Release Note
Documentation
/cc @priyawadhwa