Use SOURCE_DATE_EPOCH for OCI CreatedAt times #2878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjohnsonjr
force-pushed
the
sourcedateepoch
branch
2 times, most recently
from
0564107
to
04f283b
Compare
Codecov Report
@@ Coverage Diff @@
## main #2878 +/- ##
==========================================
- Coverage 30.40% 30.38% -0.02%
==========================================
Files 150 150
Lines 9398 9405 +7
==========================================
+ Hits 2857 2858 +1
- Misses 6102 6106 +4
- Partials 439 441 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jonjohnsonjr
force-pushed
the
sourcedateepoch
branch
from
04f283b
to
c153de9
Compare
Using time.Now() makes this unreproducible and causes a lot of churn when re-running the same command. Signed-off-by: Jon Johnson <[email protected]>
jonjohnsonjr
force-pushed
the
sourcedateepoch
branch
from
c153de9
to
236e2e1
Compare
imjasonh
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using time.Now() makes this unreproducible and causes a lot of churn when re-running the same command.
Fixes #2879
Summary
Respect SOURCE_DATE_EPOCH in OCI object generation.
Release Note
The
CreatedAttime in generated OCI images now respectsSOURCE_DATE_EPOCH.Documentation
n/a