Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support --platform for verify-attestation #3181

Closed
wants to merge 1 commit into from

Conversation

imjasonh
Copy link
Member

Summary

Support cosign verify-attestation <img> --platform=linux/arm64 ...

This flag was added to cosign download attestation in #2980, but this promotes the flag to a general-purpose registry option, which means it can be reused by cosign download <sbom|attestation> and verify-attestation, and others.

Release Note

  • Added broader support for --platform

Documentation

Generated docs are probably sufficient.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #3181 (9c49b28) into main (1c3208b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3181      +/-   ##
==========================================
- Coverage   30.54%   30.53%   -0.01%     
==========================================
  Files         155      155              
  Lines        9809     9811       +2     
==========================================
  Hits         2996     2996              
- Misses       6365     6367       +2     
  Partials      448      448              
Files Changed Coverage Δ
cmd/cosign/cli/download.go 0.00% <0.00%> (ø)
cmd/cosign/cli/options/download.go 0.00% <ø> (ø)
cmd/cosign/cli/options/registry.go 0.00% <0.00%> (ø)
cmd/cosign/cli/verify/verify_attestation.go 3.33% <ø> (ø)

@cpanato
Copy link
Member

cpanato commented Aug 14, 2023

@imjasonh can you please update the docs? :)

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions
Copy link

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants