Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -r option for recursively signing multi-arch images #320

Merged
merged 1 commit into from
May 17, 2021
Merged

Conversation

dekkagaijin
Copy link
Member

Signed-off-by: Jake Sanders [email protected]

@dekkagaijin dekkagaijin requested a review from dlorenc May 12, 2021 20:38
@dekkagaijin dekkagaijin force-pushed the recursive branch 5 times, most recently from dff1687 to a404d31 Compare May 13, 2021 17:02
if err != nil {
return err
}
for _, manifest := range idxManifest.Manifests {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always forget - is it possible to create an image that recurses even further? An index of indexes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not iiuc @jonjohnsonjr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with him and apparently recursive indexes can exist 🤮

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

walking the tree now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it hurts me that the flag is recursive but the implementation is not

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your anguish sustains me ❤️

@dekkagaijin dekkagaijin force-pushed the recursive branch 6 times, most recently from af6c7de to 2a7861e Compare May 17, 2021 06:37
@dekkagaijin dekkagaijin merged commit 5f75925 into main May 17, 2021
@dlorenc dlorenc deleted the recursive branch May 17, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants