Put secrets on github organizations

[fnxpt]

closes #3566

Summary

Currently is only possible to set secrets on a repo, adding the possibility to set it in an organization is pretty useful, since it allows to control secrets per organization instead of adding multiple secrets to individual repos.

Release Note

Allows secret creation on github organizations

[cpanato]

please sign the dco

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.41%. Comparing base (2ef6022) to head (00ae247).
Report is 54 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3567      +/-   ##
==========================================
+ Coverage   40.10%   40.41%   +0.31%     
==========================================
  Files         155      155              
  Lines       10044    10087      +43     
==========================================
+ Hits         4028     4077      +49     
+ Misses       5530     5517      -13     
- Partials      486      493       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fnxpt]

please sign the dco

@cpanato should be signed now
looks like the codecov was done on a previous commit

[fnxpt]

@cpanato can you approve the flows again? I had a lint issue

[fnxpt]

just noticed that the lint check failed again, however this doesn't seem to be related with my changes since its failing on prepare environment

[cpanato]

@fnxpt please take a look at https://github.com/sigstore/cosign/pull/3567/files#annotation_18715975046

[cpanato]

see my comment

[fnxpt]

@fnxpt please take a look at https://github.com/sigstore/cosign/pull/3567/files#annotation_18715975046

@cpanato its weird I had it without the else and got errors on the lint... anyways Im going to revert that change

[biehl1]

@cpanato are changes made by @fnxpt sufficient?

[fnxpt]

Not really sure why lint keeps complicating, I will try to run it locally but if you have any clues let me know

[cpanato]

please rebase and see if that fix it

[fnxpt]

@cpanato rebase done

[fnxpt]

@cpanato runned lint locally and manage to find the issue... I hope now it works (still no clues why its giving a lot of errors on the prepare phase)

[fnxpt]

looks ok now

[cpanato]

sorry, I would like to understand why you are doing the (g *Gh). What is the benefit of doing that and not using a internal pure function?

Suggested change

	func (g *Gh) getPublicKey(ctx context.Context, client *github.Client, owner string, repo string) (*github.PublicKey, *github.Response, error) {
	func getPublicKey(ctx context.Context, client *github.Client, owner string, repo string) (*github.PublicKey, *github.Response, error) {

same for the other one

[cpanato]

if the g had the github client that makes more sense, but it does not have, and you are passing as paramenter, i think you can drop the g thing

[fnxpt]

no reason at all, I converted the methods to functions... initially I duplicated the original function and they I cleaned the code to avoid duplicated code and I ended up by leaving this as a method

[cpanato]

functions are ok, but that does not need to be part of (g *Gh) please drop that

[cpanato]

check my comment, otherwise lgtm

[cpanato]

thanks

[fnxpt]

e2e tests are failing no space left on device

[cpanato]

@fnxpt can you please rebase? we merged this to free space #3579

[fnxpt]

rebase done

[fnxpt]

seems like the tests are still failing.... but it doesnt seem to be from the code
open ../../../go/pkg/mod/github.com/!azure/[email protected]+incompatible/services/preview/containerregistry/runtime/2019-08-15-preview/containerregistry/accesstokens.go: no such file or directory

[fnxpt]

@cpanato any update/guidance on this?

[fnxpt]

Hey guys any inputs on this? From the logs this doesn't look like an issue with the code

[haydentherapper]

Can you rebase off HEAD and we'll try to run them again?

[fnxpt]

@haydentherapper rebased

[cpanato]

thx