Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move incremental builds per commit to GHCR instead of GCR #3808

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

bobcallaway
Copy link
Member

we can backfill the entries from gcr.io/projectsigstore/cosign/ci to GHCR as well, in case anyone is using these

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.65%. Comparing base (2ef6022) to head (f5ae455).
Report is 176 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3808      +/-   ##
==========================================
- Coverage   40.10%   37.65%   -2.45%     
==========================================
  Files         155      202      +47     
  Lines       10044    12579    +2535     
==========================================
+ Hits         4028     4737     +709     
- Misses       5530     7256    +1726     
- Partials      486      586     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -67,5 +67,5 @@ jobs:
- name: containers-cosign
run: make sign-ci-containers
env:
KO_PREFIX: gcr.io/projectsigstore/cosign/ci
KO_PREFIX: ghcr.io/sigstore/cosign/cosign/ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we write up a blog post/slack message for this change?

@hectorj2f hectorj2f merged commit be43902 into sigstore:main Aug 6, 2024
22 checks passed
kipz pushed a commit to kipz/cosign that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants