fixup rust publishing #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
tnytown
reviewed
Feb 12, 2024
| @@ -18,7 +17,7 @@ prost = "0.12.3" | |||
| prost-reflect = { version = "0.12.0", features = ["serde", "derive"] } | |||
| serde = {version = "1.0", features = ["derive"]} | |||
| serde_json = "1.0" | |||
| derive = { path = "../derive" } | |||
| sigstore-protobuf-specs-derive = { version = "0.0.1", path = "../sigstore-protobuf-specs-derive" } | |||
There was a problem hiding this comment.
This would correctly resolve to sigstore-protobuf-specs-derive when it's published to crates.io, correct?
There was a problem hiding this comment.
Correct -- version is used when installed via cargo install, and path is used when installed via cargo build.
haydentherapper
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially fixes the Rust publishing situation. A new complexity: because we have a
proc-macrocrate (sigstore-protobuf-specs-derive), we really have two packages that need publishing. But only the "main" one makes any sense to automate, since the proc-macro crate should (basically) never change, and certainly doesn't need to change on the same cadence.So, here's what I propose:
sigstore-protobuf-specs-derive v0.0.1