Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added version to the signing config message. #383

Merged
merged 1 commit into from
Aug 22, 2024
Merged

added version to the signing config message. #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gen/jsonschema/schemas/ClientTrustConfig.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@
},
"dev.sigstore.trustroot.v1.SigningConfig": {
"properties": {
"mediaType": {
"type": "string",
"description": "MUST be application/vnd.dev.sigstore.signingconfig.v0.1+json"
},
"caUrl": {
"type": "string",
"description": "A URL to a Fulcio-compatible CA, capable of receiving Certificate Signing Requests (CSRs) and responding with issued certificates. This URL **MUST** be the \"base\" URL for the CA, which clients should construct an appropriate CSR endpoint on top of. For example, if `ca_url` is `https://example.com/ca`, then the client **MAY** construct the CSR endpoint as `https://example.com/ca/api/v2/signingCert`."
Expand Down
4 changes: 4 additions & 0 deletions gen/jsonschema/schemas/SigningConfig.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
"definitions": {
"SigningConfig": {
"properties": {
"mediaType": {
"type": "string",
"description": "MUST be application/vnd.dev.sigstore.signingconfig.v0.1+json"
},
"caUrl": {
"type": "string",
"description": "A URL to a Fulcio-compatible CA, capable of receiving Certificate Signing Requests (CSRs) and responding with issued certificates. This URL **MUST** be the \"base\" URL for the CA, which clients should construct an appropriate CSR endpoint on top of. For example, if `ca_url` is `https://example.com/ca`, then the client **MAY** construct the CSR endpoint as `https://example.com/ca/api/v2/signingCert`."
Expand Down
15 changes: 13 additions & 2 deletions gen/pb-go/trustroot/v1/sigstore_trustroot.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions gen/pb-python/sigstore_protobuf_specs/dev/sigstore/trustroot/v1/__init__.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions gen/pb-ruby/lib/sigstore_trustroot_pb.rb
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions gen/pb-rust/sigstore-protobuf-specs/src/generated/dev.sigstore.trustroot.v1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,9 @@ pub struct TrustedRoot {
#[allow(clippy::derive_partial_eq_without_eq)]
#[derive(Clone, PartialEq, ::prost::Message)]
pub struct SigningConfig {
/// MUST be application/vnd.dev.sigstore.signingconfig.v0.1+json
#[prost(string, tag = "5")]
pub media_type: ::prost::alloc::string::String,
/// A URL to a Fulcio-compatible CA, capable of receiving
/// Certificate Signing Requests (CSRs) and responding with
/// issued certificates.
Expand Down
Binary file modified gen/pb-rust/sigstore-protobuf-specs/src/generated/file_descriptor_set.bin
View file
Open in desktop
Binary file not shown.
6 changes: 5 additions & 1 deletion gen/pb-typescript/src/__generated__/sigstore_trustroot.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions protos/sigstore_trustroot.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,9 @@ message TrustedRoot {
// signing. In particular, it primarily contains service URLs that a Sigstore
// signer may need to connect to for the online aspects of signing.
message SigningConfig {
// MUST be application/vnd.dev.sigstore.signingconfig.v0.1+json
string media_type = 5;

// A URL to a Fulcio-compatible CA, capable of receiving
// Certificate Signing Requests (CSRs) and responding with
// issued certificates.
Expand Down
Loading