Implement certificate transparency monitoring workflow #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: linus-sun <[email protected]>
Signed-off-by: linus-sun <[email protected]>
Signed-off-by: linus-sun <[email protected]>
Signed-off-by: linus-sun <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
==========================================
- Coverage 64.02% 56.78% -7.24%
==========================================
Files 4 19 +15
Lines 303 1576 +1273
==========================================
+ Hits 194 895 +701
- Misses 78 591 +513
- Partials 31 90 +59 ☔ View full report in Codecov by Sentry. |
Signed-off-by: linus-sun <[email protected]>
linus-sun
force-pushed
the
linussun/ct-consistency-check
branch
from
8d35132
to
ced634c
Compare
|
|
||
| monitoredValues := identity.MonitoredValues{ | ||
| CertificateIdentities: config.MonitoredValues.CertificateIdentities, | ||
| Subjects: config.MonitoredValues.Subjects, |
There was a problem hiding this comment.
We don't need subjects, correct? Since subjects are just for special cases of SSH certificates or emails in keys
| return | ||
| } | ||
|
|
||
| err = ct.RunConsistencyCheck(fulcioClient, config.LogInfoFile) |
There was a problem hiding this comment.
Can we flip the order of these, to first check consistency before the identity check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per changes outlined in this doc, this PR implements the certificate transparency monitoring workflow functionality by doing the following:
ct_monitor.gofile to perform the identity monitor and consistency check functionality on a certificate transparency logThis PR depends on #527, #534, #535
Release Note
NONE
Documentation
N/A - future PRs will update documentation once the certificate transparency monitor is runnable from a reusable monitoring workflow