Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to golang 1.23.2 #2235

Merged
merged 2 commits into from
Oct 7, 2024
Merged

move to golang 1.23.2 #2235

merged 2 commits into from
Oct 7, 2024

Conversation

bobcallaway
Copy link
Member

@bobcallaway bobcallaway commented Oct 7, 2024

this disables gosec G115 (integer conversion) issues for now, will address in separate PR

Signed-off-by: Bob Callaway <[email protected]>
@bobcallaway bobcallaway requested a review from a team as a code owner October 7, 2024 13:15
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.40%. Comparing base (488eb97) to head (3a8edea).
Report is 201 commits behind head on main.

Files with missing lines Patch % Lines
pkg/generated/restapi/configure_rekor_server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2235       +/-   ##
===========================================
- Coverage   66.46%   51.40%   -15.06%     
===========================================
  Files          92      192      +100     
  Lines        9258    19590    +10332     
===========================================
+ Hits         6153    10071     +3918     
- Misses       2359     8427     +6068     
- Partials      746     1092      +346     
Flag Coverage Δ
e2etests 49.55% <ø> (+1.99%) ⬆️
unittests 43.02% <0.00%> (-4.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Bob Callaway <[email protected]>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks you did my job, was doing a similar pr :)

@bobcallaway bobcallaway enabled auto-merge (squash) October 7, 2024 13:28
@bobcallaway bobcallaway merged commit 2f12e0d into sigstore:main Oct 7, 2024
15 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants