Update Snapshot and Timestamp #1115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <[email protected]>
sigstore-bot
requested review from
bobcallaway,
haydentherapper and
kommendorkapten
|
@kommendorkapten looks like it’s missing the versioned snapshot file for some reason. |
|
https://github.com/sigstore/root-signing/actions/runs/7802585951/job/21280483584 Notes the file is present in the patch |
|
Interesting! patch applied: https://github.com/sigstore/root-signing/blob/main/.github/workflows/reuseable-snapshot-timestamp.yml#L190 Then we switch branch https://github.com/sigstore/root-signing/blob/main/.github/workflows/reuseable-snapshot-timestamp.yml#L208 Maybe we need to switch branch before applying the patch? As the previous used a workflow the branch management was not visible. |
|
The |
sigstore-review-bot
approved these changes
Feb 6, 2024
kommendorkapten
requested changes
Feb 6, 2024
Merged
|
Closing this and removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sign snapshot and timestamp files