Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor upload-coverage action #843

Merged
merged 6 commits into from
Dec 19, 2023

Conversation

jku
Copy link
Member

@jku jku commented Dec 18, 2023

Summary

Refactor upload-coverage to enable upgrading the upload-artifact and download-artifact actions (as the new upload-artifact does not allow uploading with the same name several times).

  • Use unique artifact names, then download all artifacts before combining them for coverage
  • Upgrade the actions

Release Note

N/A

@jku jku force-pushed the refactor-upload-coverage branch 10 times, most recently from eac550f to c9557a9 Compare December 18, 2023 10:11
jku and others added 4 commits December 18, 2023 12:15
upload-artifact 4.x does not support uploading multiple artifacts
with the same name. Avoid doing that in upload-coverage action.

Fixes sigstore#842

Signed-off-by: Jussi Kukkonen <[email protected]>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@a8a3f3a...c7d193f)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@a8a3f3a...c7d193f)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3.0.2 to 4.0.0.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3.0.2...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@jku
Copy link
Member Author

jku commented Dec 18, 2023

jku force-pushed the refactor-upload-coverage branch 10 times, ...

That took a few tries 😂 Looks fine now I think.

@jku jku marked this pull request as ready for review December 18, 2023 10:20
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@woodruffw woodruffw enabled auto-merge (squash) December 19, 2023 19:25
@woodruffw woodruffw merged commit 0e33a4e into sigstore:main Dec 19, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support upload-artifact / download-artifact 4.x
2 participants