Move verify logic to pkg #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hector Fernandez <[email protected]>
hectorj2f
force-pushed
the
move_verify_logic
branch
from
62e5f15
to
9c61a11
Compare
Codecov Report
@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 51.31% 51.62% +0.30%
==========================================
Files 14 15 +1
Lines 682 678 -4
==========================================
Hits 350 350
+ Misses 295 291 -4
Partials 37 37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
haydentherapper
requested changes
Nov 7, 2022
haydentherapper
requested changes
Nov 7, 2022
Signed-off-by: Hector Fernandez <[email protected]>
|
@haydentherapper Thanks for the review! I addressed all your comments. |
haydentherapper
approved these changes
Nov 8, 2022
| return verifyHashedMessages(ts.HashAlgorithm.New(), ts.HashedMessage, artifact) | ||
| } | ||
|
|
||
| func verifyTSRWithChain(ts *timestamp.Timestamp, certPool *x509.CertPool) error { |
There was a problem hiding this comment.
nit (to @malancas for the other issue): We'll want to rename this function to make it clear that this takes a trust root store (a single cert pool) rather than a chain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hector Fernandez [email protected]
Summary
related to #119
Release Note
Move verify logic to its own package.
Documentation