Require the file signer to specify the certificate chain #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because otherwise, a new cert chain would get generated in-memory on every startup. Signed-off-by: Hayden Blauzvern <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 53.24% 53.24%
=======================================
Files 15 15
Lines 678 678
=======================================
Hits 361 361
Misses 277 277
Partials 40 40 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
malancas
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because otherwise, a new cert chain would get generated in-memory on every startup.
Signed-off-by: Hayden Blauzvern [email protected]
Summary
Release Note
Documentation