-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inspect: remove format flag #155
Conversation
Signed-off-by: Hector Fernandez <[email protected]>
There is something else missing... pushing another commit |
Signed-off-by: Hector Fernandez <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 50.11% 50.00% -0.12%
==========================================
Files 18 18
Lines 846 844 -2
==========================================
- Hits 424 422 -2
Misses 376 376
Partials 46 46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
ping @cpanato |
If we don’t have any other format supported, id just say to delete the flag. |
I wasn't sure, there were other plans for the format flag. |
If there aren't, then let's remove it. |
YAGNI, we can add it back later if we add more formatting options! |
Signed-off-by: Hector Fernandez <[email protected]>
@haydentherapper I removed the flag. |
Signed-off-by: Hector Fernandez [email protected]
Summary
We didn't set any default format, so it is hard to know which options are available for the format.
Release Note
Fix: set default format value for the inspect' format flag.
Documentation