-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add intermediate and root verify flags #180
Add intermediate and root verify flags #180
Conversation
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 48.17% 46.81% -1.37%
==========================================
Files 18 18
Lines 1067 1098 +31
==========================================
Hits 514 514
- Misses 495 526 +31
Partials 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
outputContains(t, out, "Successfully verified timestamp") | ||
} | ||
|
||
func TestVerifyPassLeafCertificate(t *testing.T) { | ||
func TestVerify_RootAndIntermediateCertificateFlags(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can rewrite all or most of these verify tests as table tests in a follow up PR.
Signed-off-by: Meredith Lancaster <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just comment nits!
Co-authored-by: Hayden B <[email protected]> Signed-off-by: Meredith Lancaster <[email protected]>
Co-authored-by: Hayden B <[email protected]> Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
Summary
Part of #121
Release Note
Add
--root-certificates
and--intermediate-certificates
flags to the verify command. The client can now either pass intermediate and root certificates together using the--certificate-chain
flag or separately using these two new flags.Documentation