fix 'certficate' typo, regen files #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry S <[email protected]>
bobcallaway
reviewed
Jul 11, 2023
| @@ -350,6 +350,6 @@ func (o *TimestampServerAPI) AddMiddlewareFor(method, path string, builder middl | |||
| } | |||
| o.Init() | |||
| if h, ok := o.handlers[um][path]; ok { | |||
| o.handlers[method][path] = builder(h) | |||
| o.handlers[um][path] = builder(h) | |||
There was a problem hiding this comment.
this is an unexpected change, i wonder if we don't have the swagger tool pinned?
There was a problem hiding this comment.
There was a problem hiding this comment.
Did you run make to generate this?
There was a problem hiding this comment.
My guess is it's from updating #386, and we don't check that no files would be changed before merge.
There was a problem hiding this comment.
Did you run make to generate this?
I don't remember exactly but I think I ran go generate -x ./...
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
=======================================
Coverage 53.25% 53.25%
=======================================
Files 20 20
Lines 1198 1198
=======================================
Hits 638 638
Misses 498 498
Partials 62 62 |
haydentherapper
approved these changes
Jul 13, 2023
cpanato
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixed a minor typo (
certficatewith missingi), regenerated the filesRelease Note
NONE
Documentation
not required