Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor project to workspace #110

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Refactor project to workspace #110

merged 2 commits into from
Apr 26, 2023

Conversation

Vid201
Copy link
Member

@Vid201 Vid201 commented Apr 25, 2023

  • Refactor project to workspace
  • Add licenses to the project

This was linked to issues Apr 25, 2023
Modular ideas: split bundler, mempool and rpc into 3 crates. #88
Closed
Add license #76
Closed
Create crate primitives #91
Closed
@Vid201 Vid201 requested a review from zsluedem April 25, 2023 19:21
zsluedem
zsluedem approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work!! I only have one question. It should be good to merge.

Cargo.toml
]
default-members = ["bin/bundler"]

[profile.debug-fast]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious what this means. I could not google any good results on it. Maybe you could provide some links or description?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enables us to to do: cargo build --profile debug-fast and have debug build for debugging with high optimizations (as in release).

Link (example): https://doc.rust-lang.org/cargo/reference/profiles.html#custom-profiles

I saw this in reth and it looked useful: https://github.com/paradigmxyz/reth/blob/main/Cargo.toml

@Vid201 Vid201 merged commit d38850b into main Apr 26, 2023
@Vid201 Vid201 deleted the chore/refactor branch April 26, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsluedem zsluedem zsluedem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create crate primitives Modular ideas: split bundler, mempool and rpc into 3 crates. Add license
2 participants
@Vid201 @zsluedem