Fix call gas limit #138
Merged
Fix call gas limit #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsluedem
approved these changes
Jun 4, 2023
| @@ -459,6 +493,7 @@ mod tests { | |||
|
|
|||
| use super::*; | |||
|
|
|||
| #[ignore] | |||
There was a problem hiding this comment.
https://github.com/Vid201/aa-bundler/actions/runs/5166205480/jobs/9306373395
This is stopping me merge pr.
There was a problem hiding this comment.
It would be great to mock the case locally instead of relying on external source in test cases.
There was a problem hiding this comment.
Yeah, agree. I was thinking of removing this test case for now and revisiting it later. You can remove it in your PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes estimation for call gas limit.
Code is a little bit messy, gonna refactor with some other things in the subsequent PR.