ssz support for user operation #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsluedem
commented
Jun 28, 2023
| } | ||
| } | ||
|
|
||
| impl ssz_rs::Serialize for UserOperation { |
There was a problem hiding this comment.
@Vid201 I am handwriting this because I don't want to introduce another type of conversion. Do you have better ideas? Maybe we should wrap Bytes, U256 these kinds of types in our crates?
There was a problem hiding this comment.
Hmm, I can't think of better solution at the moment. I think this is fine for now.
Should we add some 1 or 2 tests for ssz serialize/deserialize?
Vid201
approved these changes
Jun 28, 2023
| } | ||
| } | ||
|
|
||
| impl ssz_rs::Serialize for UserOperation { |
There was a problem hiding this comment.
Hmm, I can't think of better solution at the moment. I think this is fine for now.
Should we add some 1 or 2 tests for ssz serialize/deserialize?
|
GJ! |
zsluedem
commented
Jun 29, 2023
| @@ -484,4 +758,44 @@ mod tests { | |||
| .into() | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn user_operation_ssz() { | |||
There was a problem hiding this comment.
@Vid201 add a test case
Vid201
approved these changes
Jun 29, 2023
| @@ -484,4 +758,44 @@ mod tests { | |||
| .into() | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn user_operation_ssz() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.