fix: make clean command
#187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-bao-jian
force-pushed
the
fix/make-clean
branch
from
1818f51
to
629ea60
Compare
cool Just rebased two commits into one Thanks for the tip |
|
LGTM. @da-bao-jian Just sync with main branch and CI should pass then, after that we can merge |
|
Looks like the CI is still failing. Do I need to update my own branch to include the new spec tests? Not sure if the check is run based on the Silius/main or my forked branch. |
You should rebase |
da-bao-jian
force-pushed
the
fix/make-clean
branch
from
629ea60
to
138401e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.