Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User operation pack and hash (#7) #19

Merged
merged 3 commits into from
Dec 1, 2022
Merged

User operation pack and hash (#7) #19

merged 3 commits into from
Dec 1, 2022

Conversation

Vid201
Copy link
Member

@Vid201 Vid201 commented Nov 28, 2022

No description provided.

@Vid201 Vid201 marked this pull request as ready for review December 1, 2022 09:42
@Vid201 Vid201 requested a review from zsluedem December 1, 2022 09:42
@Vid201
Copy link
Member Author

Vid201 commented Dec 1, 2022

This PR can close #22 , I would like to push that to main before continuing with #7 (I will continue then on the same PR). @zsluedem

zsluedem
zsluedem reviewed Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For d610bfb .
This is personal preference. I think it would be better to use rebase instead of merge the branch which could end up with a less merge knot in the git history. What do you think?

@Vid201
Copy link
Member Author

Vid201 commented Dec 1, 2022

For d610bfb . This is personal preference. I think it would be better to use rebase instead of merge the branch which could end up with a less merge knot in the git history. What do you think?

Yeah, that makes sense. Good suggestion!

This was linked to issues Dec 1, 2022
In-memory user operation pool #7
Closed
User operation pack and hash #22
Closed
zsluedem
zsluedem approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@Vid201 Vid201 removed a link to an issue Dec 1, 2022
In-memory user operation pool #7
Closed
@Vid201 Vid201 changed the title In-memory user operation pool (#7) User operation pack and hash (#7) Dec 1, 2022
@Vid201 Vid201 merged commit 937e8c1 into main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsluedem zsluedem zsluedem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User operation pack and hash
2 participants
@Vid201 @zsluedem