Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add public endpoint #275

Merged
merged 1 commit into from
Jan 9, 2024
Merged

doc: add public endpoint #275

merged 1 commit into from
Jan 9, 2024

Conversation

zsluedem
Copy link
Collaborator

@zsluedem zsluedem commented Jan 9, 2024

No description provided.

@zsluedem zsluedem requested a review from Vid201 as a code owner January 9, 2024 07:21
Vid201
Vid201 requested changes Jan 9, 2024
View reviewed changes
Copy link
Member

@Vid201 Vid201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🔥

I think we can merge this list and supported networks table: add another column public endpoint.

Vid201
Vid201 requested changes Jan 9, 2024
View reviewed changes
Copy link
Member

@Vid201 Vid201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have two columns - what is supported and public endpoint url? Maybe we support some network, but don't have public endpoint right away

README.md Outdated
| Optimism Goerli | https://rpc.silius.xyz/api/v1/chain/optimism-goerli |
| Optimism Sepolia | https://rpc.silius.xyz/api/v1/chain/optimism-sepolia |
| Arbitrum | :soon: |
| Arbitrum Goerli | https://rpc.silius.xyz/api/v1/chain/optimism-goerli |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong URL?

@zsluedem
Copy link
Collaborator Author

zsluedem commented Jan 9, 2024

Let's have two columns - what is supported and public endpoint url? Maybe we support some network, but don't have public endpoint right away

It is kind of wired that some networks are not supported but have public endpoints.....

@Vid201
Copy link
Member

Vid201 commented Jan 9, 2024

Let's have two columns - what is supported and public endpoint url? Maybe we support some network, but don't have public endpoint right away

It is kind of wired that some networks are not supported but have public endpoints.....

Hmm, it was like that till now. We can always leave it like that if you feel it's better.

@Vid201
Copy link
Member

Vid201 commented Jan 9, 2024

Let's have two columns - what is supported and public endpoint url? Maybe we support some network, but don't have public endpoint right away

It is kind of wired that some networks are not supported but have public endpoints.....

It can happen that some network is supported but don't have public end point yet (other way around is weird, I agree).

@zsluedem zsluedem requested a review from Vid201 January 9, 2024 13:38
@zsluedem zsluedem merged commit 0473b51 into silius-rs:main Jan 9, 2024
2 checks passed
@zsluedem zsluedem deleted the public-endpoints branch January 9, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vid201 Vid201 Vid201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zsluedem @Vid201