Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dump command #279

Merged
merged 1 commit into from
Jan 19, 2024
Merged

feat: dump command #279

merged 1 commit into from
Jan 19, 2024

Conversation

zsluedem
Copy link
Collaborator

Add a dump database command for debugging

@zsluedem zsluedem requested a review from Vid201 as a code owner January 18, 2024 02:14
@zsluedem zsluedem marked this pull request as draft January 18, 2024 03:24
@zsluedem zsluedem marked this pull request as ready for review January 18, 2024 05:23
Vid201
Vid201 reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@Vid201 Vid201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few nitpicks

bin/silius/src/cli/commands.rs Outdated Show resolved Hide resolved
bin/silius/src/cli/commands.rs Outdated Show resolved Hide resolved
bin/silius/src/cli/commands.rs Outdated Show resolved Hide resolved
bin/silius/src/cli/mod.rs Outdated Show resolved Hide resolved
@zsluedem zsluedem requested a review from Vid201 January 18, 2024 14:35
@zsluedem zsluedem merged commit 4532daa into silius-rs:main Jan 19, 2024
2 checks passed
@zsluedem zsluedem deleted the dump branch January 19, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vid201 Vid201 Vid201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zsluedem @Vid201