Add unwrap check to lint #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
zsluedem
commented
Jan 14, 2023
| } | ||
| .encode(); | ||
| packed.truncate(packed.len() - 32); | ||
| Bytes::from(packed) |
There was a problem hiding this comment.
We don't have to convert from bytes to str and then str to bytes which is unnecessary and slower. We could just operate on vec bytes.
zsluedem
commented
Jan 14, 2023
zsluedem
force-pushed
the
unwrap-check
branch
from
0d377c5
to
456b894
Compare
Vid201
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.