Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable validating tests #80

Merged
merged 4 commits into from
Jun 4, 2023
Merged

Conversation

zsluedem
Copy link
Collaborator

#66

@zsluedem
Copy link
Collaborator Author

@Vid201
Currently there are 3 validation tests failing

  1. fail_with_inner_oog_revert
  2. fail_with_unstaked_paymaster_returning_context
  3. fail_with_validation_recursively_calls_handle_ops

I am just curious whether you are working on these cases in case we are working on the dup issues.

@Vid201
Copy link
Member

Vid201 commented Mar 26, 2023

@Vid201
Currently there are 3 validation tests failing

  1. fail_with_inner_oog_revert
  2. fail_with_unstaked_paymaster_returning_context
  3. fail_with_validation_recursively_calls_handle_ops

I am just curious whether you are working on these cases in case we are working on the dup issues.

I am not working. But maybe they are the same as in bundler spec tests (I think the 2 should be same). Not sure why it's failing though.

@zsluedem zsluedem marked this pull request as ready for review May 29, 2023 04:33
@zsluedem zsluedem requested a review from Vid201 May 29, 2023 04:34
Copy link
Member

@Vid201 Vid201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

There are some conflicts now though.

@zsluedem zsluedem force-pushed the enable-validate-tests branch 2 times, most recently from 371f0b8 to 9a6422c Compare June 3, 2023 23:48
@zsluedem zsluedem merged commit df3c562 into silius-rs:main Jun 4, 2023
@zsluedem zsluedem deleted the enable-validate-tests branch June 4, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants