Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No more calling PHP code from LfMerge #173

Merged
merged 8 commits into from
Dec 8, 2021
Merged

No more calling PHP code from LfMerge #173

merged 8 commits into from
Dec 8, 2021

Commits on Dec 7, 2021

  1. Don't use a global dict in custom field handling

    @rmunn
    rmunn committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    6045840 View commit details
    Browse the repository at this point in the history

  2. MongoConnection can now update role & user views 

    This is the first step towards being able to get rid of the RunClass
code and not have our C# code call our PHP code.
    @rmunn
    rmunn committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    1c15408 View commit details
    Browse the repository at this point in the history

  3. Remove LanguageForgeProxy class entirely 

    Now that the MongoConnection knows how to update role views and user
views, this is no longer needed at all.
    @rmunn
    rmunn committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    f51090c View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Remove LanguageForgeProxyMock from unit tests

    @rmunn
    rmunn committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    65f3b82 View commit details
    Browse the repository at this point in the history

  2. Handle case where there are no user views

    @rmunn
    rmunn committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    f02fd8d View commit details
    Browse the repository at this point in the history

  3. Custom multitext fields can have FW type "String" 

    Did a bit of debugging and found that in addition to MultiString, we can
have a field type of String coming from FieldWorks for a custom field of
the most common type, which should convert to "multistring" in LF.
    @rmunn
    rmunn committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    3ea4163 View commit details
    Browse the repository at this point in the history

  4. No more pulling in PHP source in Dockerfile

    @rmunn
    rmunn committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    700d0b7 View commit details
    Browse the repository at this point in the history

  5. Delete one more now-unused method 

    The logic from this method has moved into MongoConnection
    @rmunn
    rmunn committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    88bf7c5 View commit details
    Browse the repository at this point in the history