Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic domain language setting doesn't affect Review Entries #1569

Open
johnthagen opened this issue Feb 18, 2022 · 2 comments
Open

Semantic domain language setting doesn't affect Review Entries #1569

johnthagen opened this issue Feb 18, 2022 · 2 comments
Labels
backend bug Something isn't working frontend goal: ReviewEntries lowpriority This might not be worked on refactor

Comments

@johnthagen
Copy link
Collaborator

Describe the bug

Changing the semantic domain language project setting doesn't change the language used in the Domains column of Review Entries

To Reproduce

  1. Change semantic domain project language to French
  2. Open Data entry and see French titles and descriptions
  3. Navigate to Review Entries

Screenshot 2022-02-18 093010

Expected behavior

Review entries Domain column would be translated

Environment:

  • OS: Windows
  • Browser Version: Brave

Related to #1542, #1545
@johnthagen johnthagen added bug Something isn't working frontend goal: ReviewEntries Size: S Small sized issue labels Feb 18, 2022
@johnthagen johnthagen mentioned this issue Feb 18, 2022
Merged
@imnasnainaec
Copy link
Collaborator

The domains attached to a word have a fixed language, so translating the words in the table requires a refactor of the model for semantic domains.

@imnasnainaec imnasnainaec added lowpriority This might not be worked on and removed Size: S Small sized issue labels Feb 23, 2022
@imnasnainaec
Copy link
Collaborator

What does work: when you edit an entry row and click to add a domain, the tree that pops up is in the project's semantic domain language.

@imnasnainaec imnasnainaec mentioned this issue Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend bug Something isn't working frontend goal: ReviewEntries lowpriority This might not be worked on refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imnasnainaec @johnthagen