Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export semantic domains in English #2948

Merged
merged 30 commits into from
Mar 26, 2024
Merged

Export semantic domains in English #2948

merged 30 commits into from
Mar 26, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 14, 2024

To-do:


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 78.87324% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 72.88%. Comparing base (87e1ac9) to head (12bc104).

Files Patch % Lines
src/i18n.ts 0.00% 4 Missing ⚠️
src/components/App/AppLoggedIn.tsx 0.00% 2 Missing ⚠️
...c/components/ProjectScreen/CreateProjectActions.ts 0.00% 2 Missing ⚠️
src/components/UserSettings/UserSettings.tsx 33.33% 1 Missing and 1 partial ⚠️
Backend/Services/LiftService.cs 87.50% 0 Missing and 1 partial ⚠️
src/components/ProjectScreen/ChooseProject.tsx 50.00% 1 Missing ⚠️
...mponents/ProjectSettings/ProjectSchedule/index.tsx 0.00% 1 Missing ⚠️
src/components/ProjectSettings/index.tsx 50.00% 1 Missing ⚠️
...MergeDuplicates/MergeDupsStep/SenseCardContent.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2948      +/-   ##
==========================================
+ Coverage   72.76%   72.88%   +0.12%     
==========================================
  Files         264      265       +1     
  Lines       10202    10217      +15     
  Branches     1196     1201       +5     
==========================================
+ Hits         7423     7447      +24     
+ Misses       2429     2415      -14     
- Partials      350      355       +5     
Flag Coverage Δ
backend 82.79% <92.85%> (+0.01%) ⬆️
frontend 63.69% <75.43%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review February 19, 2024 14:30
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r1, 11 of 44 files at r2, all commit messages.
Reviewable status: 12 of 47 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)


src/components/Project/ProjectActions.ts line 48 at r2 (raw file):

/** If the project's sem dom language is set to (Default to user interface language) and
 * the UI language changes, the user must leave the project and re-enter for that change

Maybe I'm tired, but this didn't quite make sense to me.

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 11 of 51 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @jasonleenaylor)


src/components/Project/ProjectActions.ts line 48 at r2 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Maybe I'm tired, but this didn't quite make sense to me.

I've updated UserSettings to remove the aforecommented disfunction.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 4 files at r1, 18 of 44 files at r2, 27 of 28 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)


src/components/WordCard/tests/SenseCard.test.tsx line 37 at r4 (raw file):

describe("SenseCard", () => {
  it("has an icon for non-Unspecified part of speech", async () => {

I found this not unconfusing.

Code quote:

non-Unspecified

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 50 of 51 files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor)


src/components/WordCard/tests/SenseCard.test.tsx line 37 at r4 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

I found this not unconfusing.

de-un-anti-tangled

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 3c646a2 into master Mar 26, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the sem-dom-lang branch March 26, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants