-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export semantic domains in English #2948
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2948 +/- ##
==========================================
+ Coverage 72.76% 72.88% +0.12%
==========================================
Files 264 265 +1
Lines 10202 10217 +15
Branches 1196 1201 +5
==========================================
+ Hits 7423 7447 +24
+ Misses 2429 2415 -14
- Partials 350 355 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 11 of 44 files at r2, all commit messages.
Reviewable status: 12 of 47 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
src/components/Project/ProjectActions.ts
line 48 at r2 (raw file):
/** If the project's sem dom language is set to (Default to user interface language) and * the UI language changes, the user must leave the project and re-enter for that change
Maybe I'm tired, but this didn't quite make sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 11 of 51 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @jasonleenaylor)
src/components/Project/ProjectActions.ts
line 48 at r2 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
Maybe I'm tired, but this didn't quite make sense to me.
I've updated UserSettings
to remove the aforecommented disfunction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 18 of 44 files at r2, 27 of 28 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
src/components/WordCard/tests/SenseCard.test.tsx
line 37 at r4 (raw file):
describe("SenseCard", () => { it("has an icon for non-Unspecified part of speech", async () => {
I found this not unconfusing.
Code quote:
non-Unspecified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 50 of 51 files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor)
src/components/WordCard/tests/SenseCard.test.tsx
line 37 at r4 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
I found this not unconfusing.
de-un-anti-tangled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
To-do:
material-react-table
#2881)This change is