Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback react-native, to avoid typescript conflicts. #1100

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 8, 2021

Global typing from react-native conficts with Typescript's lib. If we need react-native in the future, we can use a script as in DefinitelyTyped/DefinitelyTyped#15960 (comment) to remove its global typing.


This change is Reviewable

@imnasnainaec imnasnainaec added the bug Something isn't working label Apr 8, 2021
@imnasnainaec imnasnainaec self-assigned this Apr 8, 2021
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 479e503 into master Apr 8, 2021
@imnasnainaec imnasnainaec deleted the animation-rollback branch April 8, 2021 18:53
@imnasnainaec imnasnainaec mentioned this pull request Sep 7, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants