Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MergeDups] Reorganize #2366

Merged
merged 3 commits into from
Jul 11, 2023
Merged

[MergeDups] Reorganize #2366

merged 3 commits into from
Jul 11, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 10, 2023

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Patch coverage: 10.00% and project coverage change: -0.01 ⚠️

Comparison is base (e238b16) 61.08% compared to head (46dc543) 61.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2366      +/-   ##
==========================================
- Coverage   61.08%   61.08%   -0.01%     
==========================================
  Files         239      237       -2     
  Lines        8308     8294      -14     
  Branches      522      522              
==========================================
- Hits         5075     5066       -9     
+ Misses       2853     2848       -5     
  Partials      380      380              
Flag Coverage Δ
backend 74.34% <ø> (+0.06%) ⬆️
frontend 46.75% <10.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/App/DefaultState.ts 100.00% <ø> (ø)
src/components/GoalTimeline/GoalList.tsx 60.71% <ø> (ø)
src/goals/DefaultGoal/NextGoalScreen.tsx 0.00% <0.00%> (ø)
src/goals/MergeDuplicates/MergeDupsCompleted.tsx 8.57% <ø> (ø)
.../goals/MergeDuplicates/MergeDupsContinueDialog.tsx 0.00% <ø> (ø)
...plicates/MergeDupsStep/MergeDragDrop/DragSense.tsx 0.00% <ø> (ø)
...uplicates/MergeDupsStep/MergeDragDrop/DropWord.tsx 0.00% <ø> (ø)
...s/MergeDupsStep/MergeDragDrop/SidebarDragSense.tsx 0.00% <ø> (ø)
...icates/MergeDupsStep/MergeDragDrop/SidebarDrop.tsx 0.00% <ø> (ø)
...geDuplicates/MergeDupsStep/MergeDragDrop/index.tsx 0.00% <ø> (ø)
... and 10 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 35 of 36 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@jmgrady jmgrady merged commit 97e5a30 into master Jul 11, 2023
@jmgrady jmgrady deleted the merge-dups-reorg branch July 11, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants