Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Guide] Incorporate feedback #2374

Merged
merged 2 commits into from
Jul 18, 2023
Merged

[User Guide] Incorporate feedback #2374

merged 2 commits into from
Jul 18, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 14, 2023

This change is Reviewable

@imnasnainaec imnasnainaec added the documentation Improvements or additions to documentation label Jul 14, 2023
@imnasnainaec imnasnainaec self-assigned this Jul 14, 2023
@imnasnainaec imnasnainaec marked this pull request as ready for review July 14, 2023 15:40
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)


docs/user_guide/docs/goals.md line 149 at r1 (raw file):

If an imported entry or sense contains data not supported in The Combine (e.g., etymologies or sense reversals), it is
protected to prevent its deletion. If a sense is protected, its card will have a yellow background—it cannot be deleted

Another possibility:
If an imported entry or sense contains data not supported in The Combine (e.g., etymologies or sense reversals), it is
protected. The card for a protected sense is protected will have a yellow background ...

Code quote:

If an imported entry or sense contains data not supported in The Combine (e.g., etymologies or sense reversals), it is
protected to prevent its deletion. If a sense is protected, its card will have a yellow background—it cannot be deleted

@imnasnainaec imnasnainaec enabled auto-merge (squash) July 18, 2023 13:30
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit bbf6d6b into master Jul 18, 2023
@imnasnainaec imnasnainaec deleted the user-guide-feedback branch July 18, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants