Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Recorder context #2405

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Add a Recorder context #2405

merged 2 commits into from
Jul 20, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 19, 2023

Progress on #2404


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Patch coverage: 60.00% and no project coverage change.

Comparison is base (f53702e) 62.94% compared to head (c0caed9) 62.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2405   +/-   ##
=======================================
  Coverage   62.94%   62.94%           
=======================================
  Files         239      240    +1     
  Lines        8217     8215    -2     
  Branches      506      505    -1     
=======================================
- Hits         5172     5171    -1     
  Misses       2684     2684           
+ Partials      361      360    -1     
Flag Coverage Δ
backend 73.65% <ø> (ø)
frontend 50.53% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onents/DataEntry/DataEntryTable/NewEntry/index.tsx 41.17% <ø> (ø)
...omponents/DataEntry/DataEntryTable/RecentEntry.tsx 47.82% <ø> (ø)
src/components/DataEntry/DataEntryTable/index.tsx 61.86% <ø> (-0.12%) ⬇️
...ponents/Pronunciations/PronunciationsComponent.tsx 100.00% <ø> (ø)
src/components/Pronunciations/Recorder.ts 6.25% <0.00%> (ø)
...viewEntries/ReviewEntriesComponent/CellColumns.tsx 63.50% <ø> (ø)
...iesComponent/CellComponents/PronunciationsCell.tsx 0.00% <ø> (ø)
...viewEntriesComponent/Redux/ReviewEntriesReducer.ts 62.50% <0.00%> (ø)
src/components/Pronunciations/AudioRecorder.tsx 20.00% <100.00%> (+6.66%) ⬆️
src/components/Pronunciations/RecorderContext.ts 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imnasnainaec imnasnainaec enabled auto-merge (squash) July 19, 2023 16:14
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern with this is theoretical. We will have a singleton Recorder, and I'm not sure if it could ever get into a bad state after repeated use. If it could then all recording would be broken on all pages and switching pages would not fix it.
:lgtm:
:lgtm:

Reviewed 23 of 26 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 0b73312 into master Jul 20, 2023
@imnasnainaec imnasnainaec deleted the context-recorder branch July 20, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants