Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PasswordResetRequest] Eliminate info leak #2410

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 20, 2023

Resolves #2406


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jul 20, 2023
@imnasnainaec imnasnainaec enabled auto-merge (squash) July 21, 2023 15:51
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.21 🎉

Comparison is base (dcefdb1) 65.76% compared to head (c2c1c12) 65.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2410      +/-   ##
==========================================
+ Coverage   65.76%   65.97%   +0.21%     
==========================================
  Files         239      239              
  Lines        8223     8215       -8     
  Branches      504      502       -2     
==========================================
+ Hits         5408     5420      +12     
+ Misses       2457     2439      -18     
+ Partials      358      356       -2     
Flag Coverage Δ
backend 77.91% <0.00%> (-0.07%) ⬇️
frontend 52.14% <66.66%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Backend/Controllers/UserController.cs 46.09% <0.00%> (ø)
...rc/components/Login/SignUpPage/SignUpComponent.tsx 50.00% <ø> (ø)
src/components/PasswordReset/Request.tsx 83.33% <66.66%> (+83.33%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imnasnainaec imnasnainaec merged commit d9d764a into master Jul 24, 2023
@imnasnainaec imnasnainaec deleted the forgot-password-leak branch July 24, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate leaking of used emails in the forgot password page
3 participants