Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SiteSettings] Redesign with tabs #2415

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 20, 2023

Resolves #1175

Implement tabs, so you don't have to scroll down past projects to manage users or banners.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jul 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Patch coverage: 78.57% and project coverage change: +0.78 🎉

Comparison is base (d9d764a) 65.97% compared to head (03c1970) 66.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2415      +/-   ##
==========================================
+ Coverage   65.97%   66.76%   +0.78%     
==========================================
  Files         239      239              
  Lines        8215     8223       +8     
  Branches      502      504       +2     
==========================================
+ Hits         5420     5490      +70     
+ Misses       2439     2376      -63     
- Partials      356      357       +1     
Flag Coverage Δ
backend 77.98% <ø> (+0.06%) ⬆️
frontend 53.78% <78.57%> (+1.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/App/AppLoggedIn.tsx 0.00% <ø> (ø)
...omponents/SiteSettings/ProjectManagement/index.tsx 100.00% <ø> (ø)
...c/components/SiteSettings/UserManagement/index.tsx 61.53% <ø> (ø)
...omponents/SiteSettings/UserManagement/UserList.tsx 63.33% <25.00%> (+63.33%) ⬆️
src/components/SiteSettings/Banners.tsx 75.00% <100.00%> (ø)
src/components/SiteSettings/index.tsx 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imnasnainaec imnasnainaec marked this pull request as draft July 21, 2023 14:39
@imnasnainaec imnasnainaec marked this pull request as ready for review July 21, 2023 15:05
@imnasnainaec imnasnainaec mentioned this pull request Jul 21, 2023
3 tasks
@imnasnainaec imnasnainaec enabled auto-merge (squash) July 21, 2023 15:52
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 8 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 2b64344 into master Jul 24, 2023
@imnasnainaec imnasnainaec deleted the site-settings-redesign branch July 24, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign Site Settings
3 participants