Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MergeDups] Clean up state #2896

Merged
merged 5 commits into from
Jan 30, 2024
Merged

[MergeDups] Clean up state #2896

merged 5 commits into from
Jan 30, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 23, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. goal: MergeDup Size: S Small sized issue labels Jan 23, 2024
@imnasnainaec imnasnainaec self-assigned this Jan 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3d90e6) 72.86% compared to head (bdccbc9) 83.17%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2896       +/-   ##
===========================================
+ Coverage   72.86%   83.17%   +10.31%     
===========================================
  Files         264       46      -218     
  Lines       10019     4821     -5198     
  Branches     1184      576      -608     
===========================================
- Hits         7300     4010     -3290     
+ Misses       2375      672     -1703     
+ Partials      344      139      -205     
Flag Coverage Δ
backend 83.17% <ø> (-0.03%) ⬇️
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 8 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/goals/MergeDuplicates/Redux/MergeDupsReducer.ts line 265 at r2 (raw file):

        });
        state.data = { senses, words };
        state.tree = { ...defaultTree, words: wordsTree };

This is not necessary. We should not be seeking to alphabetize executable statements.

Code quote:

        state.data = { senses, words };
        state.tree = { ...defaultTree, words: wordsTree };

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit df6d632 into master Jan 30, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the merge-state branch January 30, 2024 16:16
jmgrady pushed a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend goal: MergeDup maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants