-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MergeDups] Clean up state #2896
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2896 +/- ##
===========================================
+ Coverage 72.86% 83.17% +10.31%
===========================================
Files 264 46 -218
Lines 10019 4821 -5198
Branches 1184 576 -608
===========================================
- Hits 7300 4010 -3290
+ Misses 2375 672 -1703
+ Partials 344 139 -205
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 8 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/goals/MergeDuplicates/Redux/MergeDupsReducer.ts
line 265 at r2 (raw file):
}); state.data = { senses, words }; state.tree = { ...defaultTree, words: wordsTree };
This is not necessary. We should not be seeking to alphabetize executable statements.
Code quote:
state.data = { senses, words };
state.tree = { ...defaultTree, words: wordsTree };
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This change is