-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error message for longer key requirement #3013
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3013 +/- ##
==========================================
- Coverage 72.76% 72.75% -0.01%
==========================================
Files 264 264
Lines 10201 10201
Branches 1196 1196
==========================================
- Hits 7423 7422 -1
Misses 2429 2429
- Partials 349 350 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
Backend/Startup.cs
line 109 at r1 (raw file):
// The JWT key size must be at least 256 bits long. const int minKeyLength = 256 / 8;
Is there a way to query the library instead of hard-coding this?
Code quote:
256
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Backend/Startup.cs
line 109 at r1 (raw file):
Previously, jmgrady (Jim Grady) wrote…
Is there a way to query the library instead of hard-coding this?
Good thought! I've looked and haven't found any way to. (I'm also still inclined to entirely remove this environment variable requirement and autogenerate it.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Follow-up to #2160
This change is