-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CreateProject] Improve empty name handling #3184
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3184 +/- ##
==========================================
- Coverage 74.76% 74.76% -0.01%
==========================================
Files 277 277
Lines 10636 10635 -1
Branches 1276 1278 +2
==========================================
- Hits 7952 7951 -1
Misses 2319 2319
Partials 365 365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #3173
To review, experiment in the Create Project box (on the first page you see when you login). Add and remove content from different fields (including the file upload), observing (A) when the warning text appears/disappears on the "Project Name" field, and (B) when the Submit button is disabled/enabled. Does the behavior feel intuitive, sensible?
This change is