Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MergeDupsCompleted] Give different display for deletions #3186

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 28, 2024

Resolves #3112

To review: Evaluate the new look in "Data Cleanup" > "You've Completed:" in various Merge Duplicate instances, including one where a single word was deleted and one where multiple words were deleted.


This change is Reviewable

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.63%. Comparing base (f88891f) to head (80e40f0).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
src/goals/MergeDuplicates/MergeDupsCompleted.tsx 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3186      +/-   ##
==========================================
+ Coverage   74.41%   74.63%   +0.22%     
==========================================
  Files         279      279              
  Lines       10677    10683       +6     
  Branches     1288     1289       +1     
==========================================
+ Hits         7945     7973      +28     
+ Misses       2369     2349      -20     
+ Partials      363      361       -2     
Flag Coverage Δ
backend 83.97% <ø> (+0.18%) ⬆️
frontend 66.43% <66.66%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit eb23ec1 into master Jul 30, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the merge-deleted branch July 30, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MergeDupsCompleted] Deleted word shows up as an empty word instead
2 participants