Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] Add Id (Indonesian) to sem-dom badge #3219

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 2, 2024

Follow-up to #3172

Before:
Screenshot 2024-07-02 142042

After:
Screenshot 2024-07-02 142106

This change is Reviewable

@imnasnainaec imnasnainaec added the documentation Improvements or additions to documentation label Jul 2, 2024
@imnasnainaec imnasnainaec self-assigned this Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (74f10c1) to head (14f30fe).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3219      +/-   ##
==========================================
- Coverage   74.83%   74.82%   -0.01%     
==========================================
  Files         277      277              
  Lines       10622    10622              
  Branches     1270     1270              
==========================================
- Hits         7949     7948       -1     
  Misses       2310     2310              
- Partials      363      364       +1     
Flag Coverage Δ
backend 83.84% <ø> (-0.03%) ⬇️
frontend 66.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec requested review from jmgrady and andracc and removed request for jmgrady July 2, 2024 18:36
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) July 3, 2024 17:48
@imnasnainaec imnasnainaec merged commit 98c11a3 into master Jul 3, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the readme-id branch July 3, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants