-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TreeView] Make the search textbox more recognizable #3228
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3228 +/- ##
=======================================
Coverage 74.57% 74.58%
=======================================
Files 279 279
Lines 10686 10686
Branches 1290 1290
=======================================
+ Hits 7969 7970 +1
+ Misses 2355 2354 -1
Partials 362 362
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer that we use the features of material to try and keep some ux design consistancy. Either changing the variant to outlined or filled, using InputProps. Putting the label separate in a stack is drifting from the overall design system farther than I'd like.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @imnasnainaec)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I think I misunderstood the intent of our planning meeting decision:
Modify the presentation of the Find a domain search box so that it appears as a label followed by the textbox.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @imnasnainaec)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #3190
Before:
After:
This change is