Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Make the search textbox more recognizable #3228

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 5, 2024

Resolves #3190

Before:
Screenshot 2024-07-05 110437

After:
Screenshot 2024-08-06 093651


This change is Reviewable

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (474ec40) to head (4835902).
Report is 38 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3228   +/-   ##
=======================================
  Coverage   74.57%   74.58%           
=======================================
  Files         279      279           
  Lines       10686    10686           
  Branches     1290     1290           
=======================================
+ Hits         7969     7970    +1     
+ Misses       2355     2354    -1     
  Partials      362      362           
Flag Coverage Δ
backend 83.89% <ø> (+0.02%) ⬆️
frontend 66.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that we use the features of material to try and keep some ux design consistancy. Either changing the variant to outlined or filled, using InputProps. Putting the label separate in a stack is drifting from the overall design system farther than I'd like.

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I think I misunderstood the intent of our planning meeting decision:

Modify the presentation of the Find a domain search box so that it appears as a label followed by the textbox.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit fea400d into master Aug 6, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the tree-view-search-box branch August 6, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TreeView] Improve instructions
2 participants