[DataEntryTable] Use current analysis lang with sense glosses

[imnasnainaec]

Resolves #3167

Acceptance test:

• Data Entry:
  • In semantic domain 1, create entry with vernacular form "vern" and gloss "glossA"
• Project settings:
  • In "Basic Settings" tab, make sure Autocomplete is on
  • In "Languages" tab, add a new analysis language and move it to the top of the list
• Data Entry:
  • In semantic domain 2, begin adding a new word by typing "vern" in the Vernacular text field
  • Select "vern" from the dropdown options (either by clicking it or pressing enter when it's highlighted)
  • Verify that the "Select and Entry" dialog pops up and that there is a "vern glossA" option
  • Select it (either by clicking it or pressing enter when it's highlighted)
  • Verify that the "Select a Sense" dialog appears and that there is a "glossA" option
  • Select it (either by clicking it or pressing enter when it's highlighted)
  • Verify that the dialog disappears and the Gloss text field now has the text "glossA"
  • Change the gloss text to "glossB" and press Enter
• Review Entries:
  • Verify that there is a row with "vern" in the Vernacular column and "glossA; glossB" in the Glosses column
  • Edit that row by clicking the pencil icon in the first column
  • Verify that an "Edit : vern" dialog pops up and that in the Senses section there is a single sense with two different glosses ("glossA" in the former analysis language; "glossB" in the latter analysis language)
• Data Entry:
  • In semantic domain 3, begin adding a new word by typing "vern" in the Vernacular text field
  • Select "vern" from the dropdown options (either by clicking it or pressing enter when it's highlighted)
  • Verify that the "Select and Entry" dialog pops up and that there is a "vern glossB" option
  • Select it (either by clicking it or pressing enter when it's highlighted)
  • Verify that the "Select a Sense" dialog appears and that there is a "glossB" option
  • Select it (either by clicking it or pressing enter when it's highlighted)
  • Verify that the dialog disappears and the Gloss text field now has the text "glossB"
  • Press Enter to submit the word
• Review Entries:
  • Verify that there is a row with: "vern" in the Vernacular column; "1" in the # column; "glossA; glossB" in the Glosses column; semantic domains 1, 2, and 3 in the Domains column.

---

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.76%. Comparing base (8975e57) to head (f44256c).
Report is 40 commits behind head on master.

Files with missing lines	Patch %	Lines
src/components/DataEntry/DataEntryTable/index.tsx	61.11%	4 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3239      +/-   ##
==========================================
- Coverage   74.84%   74.76%   -0.08%     
==========================================
  Files         277      277              
  Lines       10641    10652      +11     
  Branches     1279     1283       +4     
==========================================
  Hits         7964     7964              
- Misses       2314     2321       +7     
- Partials      363      367       +4     

Flag	Coverage Δ
backend	83.92% <ø> (-0.13%)	⬇️
frontend	66.69% <72.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jasonleenaylor]

Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

---

src/components/DataEntry/DataEntryTable/index.tsx line 164 at r2 (raw file):

  let glossIndex = sense.glosses.findIndex((g) => g.language === analysisLang);
  if (glossIndex === -1) {
    glossIndex = 0;

Should this actually be an error?

---

src/components/DataEntry/DataEntryTable/tests/index.test.tsx line 263 at r2 (raw file):

      expectedWord.senses[senseIndex] = { ...sense, glosses: [expectedGloss] };

      expect(updateEntryGloss(entry, def, mockSemDom.id, "")).toEqual(

I don't like this being an empty string. There is a code smell here, if we always expect it to be set in the real data having an empty string in the test data feels like a chance for a problem to sneak through in the future.

Code quote:

""

[imnasnainaec]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

---

src/components/DataEntry/DataEntryTable/index.tsx line 164 at r2 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Should this actually be an error?

No, because this parallels how we picked the gloss in the first place. The sense might not have a gloss in the current language, in which case we picked the first gloss. I'll evaluate whether there's a more connected way to do this, or at least add a comment.

---

src/components/DataEntry/DataEntryTable/tests/index.test.tsx line 263 at r2 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

I don't like this being an empty string. There is a code smell here, if we always expect it to be set in the real data having an empty string in the test data feels like a chance for a problem to sneak through in the future.

Fair. I'll work on it.

[jasonleenaylor]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)