Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter user feedback when mic access permission denied #3247

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 12, 2024

Fixes #3001


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend audio labels Jul 12, 2024
@imnasnainaec imnasnainaec self-assigned this Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.44%. Comparing base (e71754a) to head (ed9b7a3).
Report is 37 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Pronunciations/Recorder.ts 0.00% 4 Missing ⚠️
src/components/Pronunciations/RecorderContext.ts 0.00% 2 Missing ⚠️
src/components/Pronunciations/AudioRecorder.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3247   +/-   ##
=======================================
  Coverage   74.43%   74.44%           
=======================================
  Files         279      279           
  Lines       10669    10677    +8     
  Branches     1287     1288    +1     
=======================================
+ Hits         7942     7949    +7     
- Misses       2364     2366    +2     
+ Partials      363      362    -1     
Flag Coverage Δ
backend 83.87% <ø> (+0.08%) ⬆️
frontend 66.16% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review July 17, 2024 19:12
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit f88891f into master Jul 25, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the mic-access branch July 25, 2024 21:08
imnasnainaec added a commit that referenced this pull request Aug 8, 2024
Avoids uncatchable TypeError introduced in #3247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine displays an error message when user disables microphone access
2 participants