Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shell error handling for make-combine-installer.sh #3291

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

jmgrady
Copy link
Collaborator

@jmgrady jmgrady commented Aug 2, 2024

Add set -eo pipefail to make-combine-installer.sh so that the script stops if any command or command in a pipe returns an error.

This is to address the case where the script is run without the docker daemon running. It will complete with only the k3s images included; the ingress-nginx and The Combine images will be missing from the final package.


This change is Reviewable

@jmgrady jmgrady added the bash label Aug 2, 2024
@jmgrady jmgrady self-assigned this Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.54%. Comparing base (ed7de44) to head (910276d).
Report is 33 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3291      +/-   ##
==========================================
- Coverage   74.63%   74.54%   -0.09%     
==========================================
  Files         279      279              
  Lines       10683    10683              
  Branches     1289     1289              
==========================================
- Hits         7973     7964       -9     
- Misses       2349     2356       +7     
- Partials      361      363       +2     
Flag Coverage Δ
backend 83.79% <ø> (-0.19%) ⬇️
frontend 66.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@jmgrady jmgrady enabled auto-merge (squash) August 3, 2024 14:09
@jmgrady jmgrady merged commit 6392663 into master Aug 3, 2024
18 of 19 checks passed
@jmgrady jmgrady deleted the bash-error-handling branch August 3, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants