Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prettier and parentheses #3303

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Update prettier and parentheses #3303

merged 2 commits into from
Aug 15, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 14, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. dependencies Pull requests that update a dependency file Size: S Small sized issue labels Aug 14, 2024
@imnasnainaec imnasnainaec self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (f3e35ba) to head (48362d0).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3303      +/-   ##
==========================================
+ Coverage   74.60%   74.62%   +0.02%     
==========================================
  Files         279      279              
  Lines       10697    10697              
  Branches     1289     1289              
==========================================
+ Hits         7980     7983       +3     
+ Misses       2354     2351       -3     
  Partials      363      363              
Flag Coverage Δ
backend 83.87% <ø> (+0.06%) ⬆️
frontend 66.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 15, 2024 12:42
@imnasnainaec imnasnainaec merged commit 6f7e5d3 into master Aug 15, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the prettier branch August 15, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants