Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewEntry] When vern dialog closed sans choice, select text #3306

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 14, 2024

Resolves #2625 (at least as far as intended)


This change is Reviewable

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.62%. Comparing base (0ae6b66) to head (7cc0d0c).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...onents/DataEntry/DataEntryTable/NewEntry/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3306      +/-   ##
==========================================
- Coverage   74.67%   74.62%   -0.06%     
==========================================
  Files         279      279              
  Lines       10697    10698       +1     
  Branches     1289     1289              
==========================================
- Hits         7988     7983       -5     
- Misses       2347     2352       +5     
- Partials      362      363       +1     
Flag Coverage Δ
backend 83.87% <ø> (-0.11%) ⬇️
frontend 66.52% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 20, 2024 17:00
@imnasnainaec imnasnainaec merged commit 559a2de into master Aug 20, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the new-entry-close-dialog-highlight-vern branch August 20, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataEntry] Cannot exit when duplicate vernacular is unsubmitted
2 participants