Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide feedback after Vernacular name change #3408

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Conversation

andracc
Copy link
Collaborator

@andracc andracc commented Oct 24, 2024

Resolves #2661

This change is Reviewable

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.72%. Comparing base (ceaf711) to head (b5b5489).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3408      +/-   ##
==========================================
+ Coverage   74.66%   74.72%   +0.05%     
==========================================
  Files         285      285              
  Lines       10975    10978       +3     
  Branches     1335     1335              
==========================================
+ Hits         8195     8203       +8     
+ Misses       2397     2394       -3     
+ Partials      383      381       -2     
Flag Coverage Δ
backend 83.73% <ø> (+0.09%) ⬆️
frontend 66.67% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @andracc)


src/components/ProjectSettings/ProjectLanguages.tsx line 163 at r2 (raw file):

      .then(() => {
        resetState();
        setChangeVernName(false);

It's a good idea to setChangeVernName(false). Rather than doing that here, it should probably be part of resetState.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andracc)

@andracc andracc marked this pull request as ready for review October 25, 2024 14:37
@andracc andracc merged commit 55384c3 into master Oct 25, 2024
18 checks passed
@andracc andracc deleted the vernacular-feedback branch October 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Project settings there is no feedback after saving a Vernacular name change
2 participants