improve query performance and commit performance in some cases #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t once in the case of an import
…D as the state of the projected table should be latest anyway
…e ever try to add a commit that's not deferred after adding some deferred ones
…ed out due to dates getting truncated when converter to unix time milliseconds
jasonleenaylor
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously
GetCurrentObjectswould always filter on latest snapshots as a safety measure, however this is really bad for performance with a large database, and it's not nessecary considering the projected table is always the latest state. Removing the filter increases performance by an order of magnitude when a large number of commits is involved.I also added the ability to defer updating snapshots, this can be used when intending to add multiple commits at a time (for example importing a project), the snapshots will be updated once the DataModel is disposed of by the IoC container. Though it might be a good idea to expose a method to explicitly update those defered updates