Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tech support role to allowed roles when sending an invite #1835

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

megahirt
Copy link
Collaborator

@megahirt megahirt commented Sep 19, 2024

This fixes a bug where a tech support user cannot add/invite another user

Fixes #1834

Description

Looks like the tech support role was left off the list of allowed roles to send an invite.

Checklist

  • I have labeled my PR with: bug, feature, engineering, security fix or testing
  • I have performed a self-review of my own code
  • I have reviewed the title & description of this PR which I will use as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have enabled auto-merge (optional)

Testing

Verify that the repro steps in the bug report show no error message

This fixes a bug where a tech support user cannot add/invite another user
@megahirt megahirt added the bug An existing problem with our app in production label Sep 19, 2024
@megahirt megahirt self-assigned this Sep 19, 2024
Copy link

Unit Test Results

362 tests   362 ✅  14s ⏱️
 37 suites    0 💤
  1 files      0 ❌

Results for commit 062c7e3.

Copy link
Collaborator

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@megahirt megahirt merged commit 9440327 into develop Sep 20, 2024
17 checks passed
@megahirt megahirt deleted the bugfix/techSupportInvite branch September 20, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An existing problem with our app in production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: cannot invite another user when you are tech support
2 participants