Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates as highlighted by Scrutinizer #787

Merged
merged 1 commit into from
Jul 13, 2023

Commits on Jul 13, 2023

  1. Minor updates as highlighted by Scrutinizer

    - OrderTotalCalculator.php: added missing public function declarations
    - Used setField to apply values to fields in OrderProcessor.php, OrderActionsForm.php, Order.php & OrderStatusLog.php
    - OrderProcessor.php: `Company` variable exists on the Address class (not Order)
    
    Docs
    - ShoppingCartController.php: added `string` to return type
    - Product.php: added `false` as a possible return type to documentation of addLink, removeLink and removeallLink functions
    - Variation.php: added `false` as a possible return type to the Link function
    - CheckoutComponentConfig.php: corrected  docs for the getComponentByType function
    
    Removed unused variables
    - $page & $termsPage in PopulateShopTask.php
    - $success in VariationForm.php
    - $response in OrderStatusLogTest.php
    - $filterperiod in ProductReport.php
    - $record variable in imageByFilename & setParent functions in ProductBulkLoader.php
    AntonyThorpe committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    be8b4e3 View commit details
    Browse the repository at this point in the history